From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark McLoughlin Subject: [PATCH 1/4] KVM: remove the IRQ ACK notifier assertions Date: Fri, 28 Nov 2008 10:26:08 +0000 Message-ID: <1227867971-1716-1-git-send-email-markmc@redhat.com> References: <1227867951.3643.24.camel@blaa> Cc: kvm@vger.kernel.org, Sheng Yang , Mark McLoughlin To: Avi Kivity Return-path: Received: from mail24.svc.cra.dublin.eircom.net ([159.134.118.53]:39584 "HELO mail24.svc.cra.dublin.eircom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751251AbYK1K13 (ORCPT ); Fri, 28 Nov 2008 05:27:29 -0500 In-Reply-To: <1227867951.3643.24.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: We will obviously never pass a NULL struct kvm_irq_ack_notifier* to this functions. They are always embedded in the assigned device structure, so the assertion add nothing. The irqchip_in_kernel() assertion is very out of place - clearly this little abstraction needs to know nothing about the upper layer details. Signed-off-by: Mark McLoughlin --- virt/kvm/irq_comm.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c index 9fbbdea..973df99 100644 --- a/virt/kvm/irq_comm.c +++ b/virt/kvm/irq_comm.c @@ -58,9 +58,6 @@ void kvm_notify_acked_irq(struct kvm *kvm, unsigned gsi) void kvm_register_irq_ack_notifier(struct kvm *kvm, struct kvm_irq_ack_notifier *kian) { - /* Must be called with in-kernel IRQ chip, otherwise it's nonsense */ - ASSERT(irqchip_in_kernel(kvm)); - ASSERT(kian); hlist_add_head(&kian->link, &kvm->arch.irq_ack_notifier_list); } -- 1.5.4.3