From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark McLoughlin Subject: [PATCH 05/12] kvm: qemu: device-assignment: fixup error reporting Date: Fri, 28 Nov 2008 17:10:43 +0000 Message-ID: <1227892250-14386-5-git-send-email-markmc@redhat.com> References: <> <1227892250-14386-1-git-send-email-markmc@redhat.com> <1227892250-14386-2-git-send-email-markmc@redhat.com> <1227892250-14386-3-git-send-email-markmc@redhat.com> <1227892250-14386-4-git-send-email-markmc@redhat.com> Cc: kvm@vger.kernel.org, Mark McLoughlin To: Avi Kivity Return-path: Received: from mail27.svc.cra.dublin.eircom.net ([159.134.118.223]:36487 "HELO mail27.svc.cra.dublin.eircom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752133AbYK1RMJ (ORCPT ); Fri, 28 Nov 2008 12:12:09 -0500 In-Reply-To: <1227892250-14386-4-git-send-email-markmc@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: If kvm_assign_pci_device(), there's no need for us to print two lines of error messages. The string translation of errno is very useful though, so include that in the message using strerror(). Signed-off-by: Mark McLoughlin --- qemu/hw/device-assignment.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c index b5cf6ee..2b2ef68 100644 --- a/qemu/hw/device-assignment.c +++ b/qemu/hw/device-assignment.c @@ -540,12 +540,11 @@ struct PCIDevice *init_assigned_device(AssignedDevInfo *adev, PCIBus *bus) if (r && !adev->disable_iommu) assigned_dev_data.flags |= KVM_DEV_ASSIGN_ENABLE_IOMMU; #endif - + r = kvm_assign_pci_device(kvm_context, &assigned_dev_data); if (r < 0) { - fprintf(stderr, "Could not notify kernel about " - "assigned device \"%s\"\n", adev->name); - perror("register_real_device"); + fprintf(stderr, "Failed to assign device \"%s\" : %s\n", + adev->name, strerror(-r)); goto out; } -- 1.5.4.3