From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark McLoughlin Subject: [PATCH 06/12] kvm: qemu: device-assignment: cleanup irq assignment error messages Date: Fri, 28 Nov 2008 17:10:44 +0000 Message-ID: <1227892250-14386-6-git-send-email-markmc@redhat.com> References: <> <1227892250-14386-1-git-send-email-markmc@redhat.com> <1227892250-14386-2-git-send-email-markmc@redhat.com> <1227892250-14386-3-git-send-email-markmc@redhat.com> <1227892250-14386-4-git-send-email-markmc@redhat.com> <1227892250-14386-5-git-send-email-markmc@redhat.com> Cc: kvm@vger.kernel.org, Mark McLoughlin To: Avi Kivity Return-path: Received: from mail14.svc.cra.dublin.eircom.net ([159.134.118.30]:39530 "HELO mail14.svc.cra.dublin.eircom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751954AbYK1RMI (ORCPT ); Fri, 28 Nov 2008 12:12:08 -0500 In-Reply-To: <1227892250-14386-5-git-send-email-markmc@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Replace perror() usage with sane error message. Signed-off-by: Mark McLoughlin --- qemu/hw/device-assignment.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c index 2b2ef68..b39617a 100644 --- a/qemu/hw/device-assignment.c +++ b/qemu/hw/device-assignment.c @@ -473,9 +473,10 @@ void assigned_dev_update_irq(PCIDevice *d) assigned_irq_data.host_irq = assigned_dev->real_device.irq; r = kvm_assign_irq(kvm_context, &assigned_irq_data); if (r < 0) { - perror("assigned_dev_update_irq"); - fprintf(stderr, "Are you assigning a device " - "that shares IRQ with some other device?\n"); + fprintf(stderr, "Failed to assign irq for \"%s\": %s\n", + adev->name, strerror(-r)); + fprintf(stderr, "Perhaps you re you assigning a device " + "that shares IRQ with another device?\n"); pci_unregister_device(&assigned_dev->dev); /* FIXME: Delete node from list */ continue; -- 1.5.4.3