From: Hollis Blanchard <hollisb@us.ibm.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Avi Kivity <avi@redhat.com>,
"Zhang, Xiantao" <xiantao.zhang@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>
Subject: Re: [PATCH] KVM: Qemu: push_nmi should be only used by I386 Arch.
Date: Mon, 01 Dec 2008 17:18:06 -0600 [thread overview]
Message-ID: <1228173486.14874.65.camel@localhost.localdomain> (raw)
In-Reply-To: <49346D0D.1020505@web.de>
On Tue, 2008-12-02 at 00:02 +0100, Jan Kiszka wrote:
> >
> > Guys, we already have stubs for this (although they've been turned into
> > dead code). Jan broke IA64 and PowerPC builds when he renamed
> > "kvm_arch_try_push_nmi" to "kvm_arch_push_nmi", and the obvious fix is
> > to update the stubs to match. That avoids all these ifdefs and
> > associated problems.
>
> Ouch - I'm sorry.
Well, it happens, but I do wish that more people would use cscope or
even grep to find all users of a symbol.
I also wish that Avi would get his PPC box working so he could catch
build breaks like these. Cross-compilers would do as well.
I would also like a pony.
> > Avi, could you revert a8d12f98755be9330fcde055134511f76ecaa538 please?
> >
>
> Here is a patch that reverts change and fixes the root of the issue.
Acked-by: Hollis Blanchard <hollisb@us.ibm.com>
--
Hollis Blanchard
IBM Linux Technology Center
next prev parent reply other threads:[~2008-12-01 23:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 9:36 [PATCH] KVM: Qemu: push_nmi should be only used by I386 Arch Zhang, Xiantao
2008-11-27 11:39 ` Jan Kiszka
2008-11-28 1:47 ` Zhang, Xiantao
2008-11-28 9:26 ` Jan Kiszka
2008-12-01 16:38 ` Hollis Blanchard
2008-12-01 23:02 ` Jan Kiszka
2008-12-01 23:18 ` Hollis Blanchard [this message]
2008-12-02 9:26 ` Avi Kivity
2008-12-02 2:01 ` Zhang, Xiantao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228173486.14874.65.camel@localhost.localdomain \
--to=hollisb@us.ibm.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm-ia64@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox