From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [PATCH] KVM: Qemu: push_nmi should be only used by I386 Arch. Date: Mon, 01 Dec 2008 17:18:06 -0600 Message-ID: <1228173486.14874.65.camel@localhost.localdomain> References: <706158FABBBA044BAD4FE898A02E4BC219BCA9F5@pdsmsx503.ccr.corp.intel.com> <492E86FD.1040903@siemens.com> <706158FABBBA044BAD4FE898A02E4BC219BCAB6B@pdsmsx503.ccr.corp.intel.com> <492FB95C.4030702@siemens.com> <1228149488.14874.15.camel@localhost.localdomain> <49346D0D.1020505@web.de> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Avi Kivity , "Zhang, Xiantao" , "kvm@vger.kernel.org" , "kvm-ia64@vger.kernel.org" To: Jan Kiszka Return-path: Received: from e32.co.us.ibm.com ([32.97.110.150]:38990 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbYLAXSK (ORCPT ); Mon, 1 Dec 2008 18:18:10 -0500 In-Reply-To: <49346D0D.1020505@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 2008-12-02 at 00:02 +0100, Jan Kiszka wrote: > > > > Guys, we already have stubs for this (although they've been turned into > > dead code). Jan broke IA64 and PowerPC builds when he renamed > > "kvm_arch_try_push_nmi" to "kvm_arch_push_nmi", and the obvious fix is > > to update the stubs to match. That avoids all these ifdefs and > > associated problems. > > Ouch - I'm sorry. Well, it happens, but I do wish that more people would use cscope or even grep to find all users of a symbol. I also wish that Avi would get his PPC box working so he could catch build breaks like these. Cross-compilers would do as well. I would also like a pony. > > Avi, could you revert a8d12f98755be9330fcde055134511f76ecaa538 please? > > > > Here is a patch that reverts change and fixes the root of the issue. Acked-by: Hollis Blanchard -- Hollis Blanchard IBM Linux Technology Center