Re: [PATCH 05/13] add domain flag DOMAIN_FLAG_VIRTUAL_MACHINE

[Mark McLoughlin <markmc@redhat.com>]

On Tue, 2008-12-02 at 22:22 +0800, Han, Weidong wrote:
> By default, one domain owns one device, like native VT-d usage.
> 
> For kvm VT-d usage, more than one devices across iommus may be
> assigned to one domain, flag DOMAIN_FLAG_VIRTUAL_MACHINE is for this
> usage.
> 
> Signed-off-by: Weidong Han <weidong.han@intel.com>
> ---
>  drivers/pci/intel-iommu.c     |    3 ++-
>  include/linux/dma_remapping.h |   11 ++++++++++-
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
> index fa1507b..09a5150 100644
> --- a/drivers/pci/intel-iommu.c
> +++ b/drivers/pci/intel-iommu.c
> @@ -989,6 +989,7 @@ static struct dmar_domain * iommu_alloc_domain(struct intel_iommu *iommu)
>  		domain->iommu_coherency = 0;
>  
>  	iommu->domains[num] = domain;
> +	domain->flags = 0;
>  	spin_unlock_irqrestore(&iommu->lock, flags);

This looks like a bugfix. Does it need to be fixed in 2.6.28?

>  
>  	return domain;
> @@ -1387,7 +1388,7 @@ static struct dmar_domain *get_domain_for_dev(struct pci_dev *pdev, int gaw)
>  		info->dev = NULL;
>  		info->domain = domain;
>  		/* This domain is shared by devices under p2p bridge */
> -		domain->flags |= DOMAIN_FLAG_MULTIPLE_DEVICES;
> +		domain->flags |= DOMAIN_FLAG_P2P_MULTIPLE_DEVICES;

Renaming this flag should probably be a separate patch.

Cheers,
Mark.