From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark McLoughlin <markmc@redhat.com>
Subject: Re: [PATCH 05/13] add domain flag DOMAIN_FLAG_VIRTUAL_MACHINE
Date: Thu, 04 Dec 2008 17:12:46 +0000
Message-ID: <1228410766.3732.140.camel@blaa>
References: <715D42877B251141A38726ABF5CABF2C018BF0598B@pdsmsx503.ccr.corp.intel.com>
Reply-To: Mark McLoughlin <markmc@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: "'Avi Kivity'" <avi@redhat.com>,
	"Woodhouse, David" <david.woodhouse@intel.com>,
	"'Jesse Barnes'" <jbarnes@virtuousgeek.org>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	"'iommu@lists.linux-foundation.org'"
	<iommu@lists.linux-foundation.org>,
	"'kvm@vger.kernel.org'" <kvm@vger.kernel.org>
To: "Han, Weidong" <weidong.han@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:35309 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753222AbYLDROT (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 4 Dec 2008 12:14:19 -0500
In-Reply-To: <715D42877B251141A38726ABF5CABF2C018BF0598B@pdsmsx503.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, 2008-12-02 at 22:22 +0800, Han, Weidong wrote:
> By default, one domain owns one device, like native VT-d usage.
> 
> For kvm VT-d usage, more than one devices across iommus may be
> assigned to one domain, flag DOMAIN_FLAG_VIRTUAL_MACHINE is for this
> usage.
> 
> Signed-off-by: Weidong Han <weidong.han@intel.com>
> ---
>  drivers/pci/intel-iommu.c     |    3 ++-
>  include/linux/dma_remapping.h |   11 ++++++++++-
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
> index fa1507b..09a5150 100644
> --- a/drivers/pci/intel-iommu.c
> +++ b/drivers/pci/intel-iommu.c
> @@ -989,6 +989,7 @@ static struct dmar_domain * iommu_alloc_domain(struct intel_iommu *iommu)
>  		domain->iommu_coherency = 0;
>  
>  	iommu->domains[num] = domain;
> +	domain->flags = 0;
>  	spin_unlock_irqrestore(&iommu->lock, flags);

This looks like a bugfix. Does it need to be fixed in 2.6.28?

>  
>  	return domain;
> @@ -1387,7 +1388,7 @@ static struct dmar_domain *get_domain_for_dev(struct pci_dev *pdev, int gaw)
>  		info->dev = NULL;
>  		info->domain = domain;
>  		/* This domain is shared by devices under p2p bridge */
> -		domain->flags |= DOMAIN_FLAG_MULTIPLE_DEVICES;
> +		domain->flags |= DOMAIN_FLAG_P2P_MULTIPLE_DEVICES;

Renaming this flag should probably be a separate patch.

Cheers,
Mark.