From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark McLoughlin Subject: Re: [PATCH 08/13] allocation and free functions of virtual machine domain Date: Fri, 05 Dec 2008 09:20:19 +0000 Message-ID: <1228468819.3858.7.camel@blaa> References: <715D42877B251141A38726ABF5CABF2C018BF0598E@pdsmsx503.ccr.corp.intel.com> <1228410780.3732.143.camel@blaa> <20081204231706.GO29705@8bytes.org> Reply-To: Mark McLoughlin Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "Han, Weidong" , "Yu, Fenghua" , "Woodhouse, David" , "'kvm@vger.kernel.org'" , "'Jesse Barnes'" , "'iommu@lists.linux-foundation.org'" , "'Avi Kivity'" To: Joerg Roedel Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45233 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbYLEJVr (ORCPT ); Fri, 5 Dec 2008 04:21:47 -0500 In-Reply-To: <20081204231706.GO29705@8bytes.org> Sender: kvm-owner@vger.kernel.org List-ID: Hi Joerg, On Fri, 2008-12-05 at 00:17 +0100, Joerg Roedel wrote: > > Again, these new functions are copies of existing code with minor > > modifications. I'd much rather see the existing code refactored and then > > modified to handle the DOMAIN_FLAG_VIRTUAL_MACHINE case. > > Hey Mark, > > can your objections be fixed by follow-up patches bei Han or is anything > critical in it? My AMD IOMMU patches for KVM support depend on these > patches and everything they are changed I have to rebase by work. So I > would prefer if Han can fix the issues found by follow-up patches :) Well, Weidong is going to have to rebase to dwmw2's tree anyway. I assume he'll fix at least some of the issues in the process of doing that. But you're right in that nothing I pointed out was a complete showstopper, just ways in which things could be done more cleanly. Cheers, Mark.