From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Vivier Subject: Re: [Bochs-developers] [PATCH][BIOS] Fill IPL table accordingdiscovered ATA drives Date: Mon, 08 Dec 2008 11:05:30 +0100 Message-ID: <1228730730.4025.2.camel@frecb07144> References: <1228494009-20270-1-git-send-email-Laurent.Vivier@bull.net> <4A58ABD7D38C471D9D5865C3E634515E@FSCPC> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: bochs-developers@lists.sourceforge.net, kvm@vger.kernel.org To: Sebastian Herbszt Return-path: Received: from ecfrec.frec.bull.fr ([129.183.4.8]:39202 "EHLO ecfrec.frec.bull.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516AbYLHKE6 (ORCPT ); Mon, 8 Dec 2008 05:04:58 -0500 In-Reply-To: <4A58ABD7D38C471D9D5865C3E634515E@FSCPC> Sender: kvm-owner@vger.kernel.org List-ID: Le dimanche 07 d=C3=A9cembre 2008 =C3=A0 19:11 +0100, Sebastian Herbszt= a =C3=A9crit : > Laurent Vivier wrote: > > This patch shows in boot menu only available devices. > >=20 > > This patch has been tested with Bochs BIOS version from the KVM sou= rce tree. > >=20 > > Signed-off-by: Laurent Vivier > > --- > > bios/rombios.c | 54 +++++++++++++++++++++++++++++++++++++--------= --------- > > 1 files changed, 37 insertions(+), 17 deletions(-) > >=20 > > diff --git a/bios/rombios.c b/bios/rombios.c > > index 70b3584..d2a7c09 100644 > > --- a/bios/rombios.c > > +++ b/bios/rombios.c > > @@ -1981,18 +1981,6 @@ init_boot_vectors() > > memcpyb(IPL_SEG, IPL_TABLE_OFFSET + count * sizeof (e), ss, &e, s= izeof (e)); > > count++; > >=20 > > - /* First HDD */ > > - e.type =3D IPL_TYPE_HARDDISK; e.flags =3D 0; e.vector =3D 0; e.d= escription =3D 0; e.reserved =3D 0; > > - memcpyb(IPL_SEG, IPL_TABLE_OFFSET + count * sizeof (e), ss, &e, = sizeof (e)); > > - count++; >=20 > We need this bit for the !BX_USE_ATADRV case. Please "#if !BX_USE_ATA= DRV ... #endif" it > instead of removing. If there is no ATA drive, what is the aim of adding an harddrive in the= IPL table ? Thank you for all your comments (I'm going to resend the two patches) Regards, Laurent --=20 ------------------ Laurent.Vivier@bull.net ------------------ "Tout ce qui est impossible reste =C3=A0 accomplir" Jules Verne "Things are only impossible until they're not" Jean-Luc Picard