Re: [PATCH] virtio: make PCI devices take a virtio_pci module ref

Anthony Liguori
2008-12-08T14:47:00Z

Mark McLoughlin wrote:
> On Sun, 2008-12-07 at 18:52 +1030, Rusty Russell wrote:
>
>> On Saturday 06 December 2008 01:37:06 Mark McLoughlin wrote:
>>
>>> Another example of a lack of an explicit dependency causing problems is
>>> Fedora's mkinitrd having this hack:
>>>
>>> if echo $PWD | grep -q /virtio-pci/ ; then
>>> findmodule virtio_pci
>>> fi
>>>
>>> which basically says "if this is a virtio device, don't forget to
>>> include virtio_pci in the initrd too!". Now, mkinitrd is full of hacks,
>>> but this is a particularly unusual one.
>>>
>> Um, I don't know what this does, sorry.
>>
>> I have no idea how Fedora chooses what to put in an initrd; I can't think
>> of a sensible way of deciding what goes in and what doesn't other than
>> lists and heuristics.
>>
>
> Fedora's mkinitrd creates an initrd suitable to boot the machine you run
> mkinitrd on, rather than creating an initrd suitable to boot any
> machine.
>
> So, it goes "ah, / is mounted from /dev/vda, we need to include
> virtio_blk and it's dependencies". It does that in a generic way that
> works well for most setups:
>
> 1) Find the device name (e.g. vda) below /sys/block
>
> 2) Follow the 'device' link to e.g. /sys/devices/virtio-pci/virtio1
>
> 3) Find the module need for this through either 'modalias' or the
> 'driver/module' symlink
>
> 4) Use modprobe to list any dependencies of that module
>
> Clearly, virtio-pci won't be pulled in by any of this so we've added a
> hack to say "oh, it's a virtio device, let's include virtio_pci just in
> case".
>
> It's not even the case that mkinitrd needs to know how to include the
> the module for the bus, because in our case that's virtio.ko ... we've
> pretty effectively hidden the the bus *implementation* from userspace.
>
> I don't think this is worth wasting too much time fixing, that's why I'm
> thinking we should just make virtio_pci built-in by default with
> CONFIG_KVM_GUEST.
>

What if we have multiple virtio transports? Is there a way that we can
expose the relationship with virtio-blk and virtio-pci in sysfs? We
have a struct device for the PCI device, it's just a matter of making
the link visible.

Regards,

Anthony Liguori

Regards,

Anthony Liguori

>> But there really is no explicit dependency between virtio modules and
>> virtio_pci. There just is for kvm/x86 at the moment, since that is how
>> they use virtio. Running over another bus is certainly possible,
>> though may never happen for x86 (happens today for s390).
>>
>
> Right, and in the case of both kvm/s390 and lguest the bus
> implementation is built-in, not a module.
>
> Cheers,
> Mark.
>
>