Re: [PATCH 1/4] kvm: qemu: Remove the useless parameter of assigned_dev_update_irq

[Mark McLoughlin <markmc@redhat.com>]

On Wed, 2008-12-10 at 17:44 +0800, Han, Weidong wrote:
> Should pass &assigned_dev->dev to ipf_map_irq in while loop.
> 
> Signed-off-by: Weidong Han <weidong.han@intel.com>
> ---
>  qemu/hw/device-assignment.c |    4 ++--
>  qemu/hw/pci.c               |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
> index 4a38a22..7240158 100644
> --- a/qemu/hw/device-assignment.c
> +++ b/qemu/hw/device-assignment.c
> @@ -491,7 +491,7 @@ static uint32_t calc_assigned_dev_id(uint8_t bus, uint8_t devfn)
>  /* The pci config space got updated. Check if irq numbers have changed
>   * for our devices
>   */
> -void assigned_dev_update_irq(PCIDevice *d)
> +void assigned_dev_update_irq()

Yes, but perhaps also rename to update_assigned_device_irqs() ?

(i.e. the current name implies that it's an operation on a single
assigned device, rather than an operation on all assigned devices)

Cheers,
Mark.