From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark McLoughlin Subject: [PATCH] kvm: qemu: device-assignment: really exit if cmdline parsing fails Date: Wed, 10 Dec 2008 10:23:43 +0000 Message-ID: <1228904623.5384.44.camel@blaa> References: <> <1227892250-14386-1-git-send-email-markmc@redhat.com> <1227892250-14386-2-git-send-email-markmc@redhat.com> <1227892250-14386-3-git-send-email-markmc@redhat.com> Reply-To: Mark McLoughlin Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42382 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754856AbYLJKZJ (ORCPT ); Wed, 10 Dec 2008 05:25:09 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mBAAP9AX001115 for ; Wed, 10 Dec 2008 05:25:09 -0500 In-Reply-To: <1227892250-14386-3-git-send-email-markmc@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 2008-11-28 at 17:10 +0000, Mark McLoughlin wrote: > It's standard practice in qemu to exit if command line parameter > fails, so do that here too. > > Signed-off-by: Mark McLoughlin > --- > qemu/hw/device-assignment.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c > index eb2a73a..8fbd66c 100644 > --- a/qemu/hw/device-assignment.c > +++ b/qemu/hw/device-assignment.c > @@ -620,6 +620,7 @@ void add_assigned_devices(PCIBus *bus, const char **devices, int n_devices) > if (!adev) { > fprintf(stderr, "Could not add assigned device %s\n", devices[i]); > continue; > + exit(1); Um, that's a rather embarrassing thinko. Cheers, Mark. From: Mark McLoughlin Subject: [PATCH] kvm: qemu: device-assignment: really exit if cmdline parsing fails Signed-off-by: Mark McLoughlin --- qemu/hw/device-assignment.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c index 4a38a22..7a66665 100644 --- a/qemu/hw/device-assignment.c +++ b/qemu/hw/device-assignment.c @@ -668,7 +668,6 @@ void add_assigned_devices(PCIBus *bus, const char **devices, int n_devices) adev = add_assigned_device(devices[i]); if (!adev) { fprintf(stderr, "Could not add assigned device %s\n", devices[i]); - continue; exit(1); } -- 1.5.4.3