From: Alexander Graf <agraf@suse.de>
To: kvm@vger.kernel.org
Cc: avi@redhat.com
Subject: [PATCH] Fix KVM includes in helper.c
Date: Mon, 22 Dec 2008 17:54:10 +0100 [thread overview]
Message-ID: <1229964850-23316-1-git-send-email-agraf@suse.de> (raw)
By default target-i386/helper.c does not include config.h, so
no code in there knows if we're enabling KVM or not.
This breaks the nested activation, as that's depending on the
config options.
Of course, with this patch applied the CPUID KVM checks are
applied twice, as now kvm_enabled() does not default to true
for the cpuid helper functions. Maybe it's a good idea to
remove the qemu-kvm-x86.c cpuid code?
This patch fixes compilation broken thanks to my nested SVM
patches.
Signed-off-by: Alexander Graf <agraf@suse.de>
---
qemu/qemu-kvm.h | 1 +
qemu/target-i386/helper.c | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/qemu/qemu-kvm.h b/qemu/qemu-kvm.h
index 154ff63..7224820 100644
--- a/qemu/qemu-kvm.h
+++ b/qemu/qemu-kvm.h
@@ -161,6 +161,7 @@ int qemu_kvm_has_sync_mmu(void);
void kvm_init_vcpu(CPUState *env);
#else
#define kvm_enabled() (0)
+#define kvm_nested 0
#define qemu_kvm_irqchip_in_kernel() (0)
#define qemu_kvm_pit_in_kernel() (0)
#define kvm_has_sync_mmu() (0)
diff --git a/qemu/target-i386/helper.c b/qemu/target-i386/helper.c
index 1c5b85c..04da2b0 100644
--- a/qemu/target-i386/helper.c
+++ b/qemu/target-i386/helper.c
@@ -30,6 +30,7 @@
#include "qemu-common.h"
#include "kvm.h"
+#include "config.h"
#include "qemu-kvm.h"
//#define DEBUG_MMU
--
1.5.6
next reply other threads:[~2008-12-22 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-22 16:54 Alexander Graf [this message]
2008-12-24 10:38 ` [PATCH] Fix KVM includes in helper.c Avi Kivity
2008-12-24 10:49 ` Alexander Graf
2008-12-24 11:33 ` Avi Kivity
2008-12-24 10:58 ` Alexander Graf
2008-12-24 11:38 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229964850-23316-1-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox