Re: [PATCH 1/3] KVM: Add MSI_ACTION flag for assigned irq

Sheng Yang
2008-12-30T10:26:28Z

On Tuesday 30 December 2008 18:19:29 Avi Kivity wrote:
> Sheng Yang wrote:
> > For MSI disable feature later.
> >
> > Notice I changed ABI here, but due to no userspace patch, I think it's
> > OK.
>
> It's not okay, since eventually we will have userspace and it will have
> to work with older kernels as well.
>
> No released kernel has KVM_DEV_IRQ_ASSIGN_ENABLE_MSI, so it's fine,
> provided I fold this into the 2.6.29 submission. However, why do this
> at all? It can only cause confusion.

If we have ENABLE_MSI, and DISABLE, and ENABLE_MSIX, and DISABLE, and
MASK_MSIX, and UNMASK, every two action are in pairs but we have to use twice
bits to store them. So I'd like to use MSI_ACTION approach...

--
regards
Yang, Sheng