From: Andrew Jones <drjones@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
christoffer dall <christoffer.dall@linaro.org>,
marc zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off
Date: Tue, 16 Sep 2014 08:57:31 -0400 (EDT) [thread overview]
Message-ID: <1230672875.5036288.1410872251140.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <5418315B.6020201@redhat.com>
----- Original Message -----
> Il 16/09/2014 14:43, Andrew Jones ha scritto:
> > I don't think we need to worry about this case. AFAIU, enabling the
> > caches for a particular cpu shouldn't require any synchronization.
> > So we should be able to do
> >
> > enable caches
> > spin_lock
> > start other processors
> > spin_unlock
>
> Ok, I'll test and apply your patch then.
>
> Once you change the code to enable caches, please consider hanging on
> spin_lock with caches disabled.
Unfortunately I can't do that without changing spin_lock into a wrapper
function. Early setup code calls functions that use spin_locks, e.g.
puts(), and we won't want to move the cache enablement into early setup
code, as that should be left for unit tests to turn on off as they wish.
Thus we either need to be able to change the spin_lock implementation
dynamically, or just leave the test/return as is.
drew
>
> Paolo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-09-16 12:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 2:06 [PATCH kvm-unit-tests] arm: fix crash when caches are off Andrew Jones
2014-09-16 8:14 ` Paolo Bonzini
2014-09-16 12:12 ` Andrew Jones
2014-09-16 12:28 ` Paolo Bonzini
2014-09-16 12:43 ` Andrew Jones
2014-09-16 12:47 ` Paolo Bonzini
2014-09-16 12:51 ` Andrew Jones
2014-09-16 14:38 ` Andrew Jones
2014-09-16 18:04 ` Andrew Jones
2014-09-16 12:57 ` Andrew Jones [this message]
2014-09-26 7:51 ` Christoffer Dall
2014-10-30 15:59 ` Andrew Jones
2014-09-16 12:48 ` Andrew Jones
2014-09-18 10:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230672875.5036288.1410872251140.JavaMail.zimbra@redhat.com \
--to=drjones@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox