Re: [ANNOUNCE] kvm-83 release

[Mark McLoughlin <markmc@redhat.com>]

Hi John,

On Wed, 2009-01-14 at 00:15 +0800, John Wong wrote:
> Hi, i installed kvm-83 on xubuntu-amd64/kernel-2.6.7-11.
> i notice some problem with -net downscript.
> my kvm start up script like this:
> qemu-system-x86_64 ... ... -net 
> tap,ifname=tap0,script=/path/kvm-ifup,downscript=/path/kvm-ifdown
> when the guest shutdown, kvm pass all argument to downscript.
> 
> the command like this (kvm-83):
> /path/kvm-ifdown
> "tap0,script=/path/kvm-ifup,downscript=/path/kvm-ifdown"
> 
> kvm-82 only pass tap0 to downscript like this:
> /path/kvm-ifdown "tap0"

Thanks for the report. Can you try this simple change and see if it
fixes it for you?

--- qemu/net.c
+++ qemu/net.c
@@ -1740,7 +1740,7 @@ void net_cleanup(void)
                 TAPState *s = vc->opaque;
 
                 if (strcmp(vc->model, "tap") == 0 &&
-                    sscanf(vc->info_str, "ifname=%63s ", ifname) == 1 &&
+                    sscanf(vc->info_str, "ifname=%63s,", ifname) == 1 &&
                     s->down_script[0])
                     launch_script(s->down_script, ifname, s->fd);
             }

Thanks,
Mark.