From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark McLoughlin <markmc@redhat.com>
Subject: Re: [ANNOUNCE] kvm-83 release
Date: Tue, 13 Jan 2009 17:27:33 +0000
Message-ID: <1231867653.4290.196.camel@localhost.localdomain>
References: <496C9CE0.2080103@redhat.com>  <496CBE09.4060801@wonghome.net>
Reply-To: Mark McLoughlin <markmc@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, KVM list <kvm@vger.kernel.org>
To: John Wong <johnw@wonghome.net>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:41051 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752665AbZAMR1i (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 13 Jan 2009 12:27:38 -0500
In-Reply-To: <496CBE09.4060801@wonghome.net>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hi John,

On Wed, 2009-01-14 at 00:15 +0800, John Wong wrote:
> Hi, i installed kvm-83 on xubuntu-amd64/kernel-2.6.7-11.
> i notice some problem with -net downscript.
> my kvm start up script like this:
> qemu-system-x86_64 ... ... -net 
> tap,ifname=tap0,script=/path/kvm-ifup,downscript=/path/kvm-ifdown
> when the guest shutdown, kvm pass all argument to downscript.
> 
> the command like this (kvm-83):
> /path/kvm-ifdown
> "tap0,script=/path/kvm-ifup,downscript=/path/kvm-ifdown"
> 
> kvm-82 only pass tap0 to downscript like this:
> /path/kvm-ifdown "tap0"

Thanks for the report. Can you try this simple change and see if it
fixes it for you?

--- qemu/net.c
+++ qemu/net.c
@@ -1740,7 +1740,7 @@ void net_cleanup(void)
                 TAPState *s = vc->opaque;
 
                 if (strcmp(vc->model, "tap") == 0 &&
-                    sscanf(vc->info_str, "ifname=%63s ", ifname) == 1 &&
+                    sscanf(vc->info_str, "ifname=%63s,", ifname) == 1 &&
                     s->down_script[0])
                     launch_script(s->down_script, ifname, s->fd);
             }

Thanks,
Mark.