Re: [PATCH 1/2] kvm: libkvm: support for irq routing

Avi Kivity
2009-01-15T09:59:46Z

Sheng Yang wrote:
> On Thursday 15 January 2009 14:17:16 Sheng Yang wrote:
>
>> On Wednesday 14 January 2009 21:53:10 Avi Kivity wrote:
>>
>>> Signed-off-by: Avi Kivity <avi@redhat.com>
>>>
>> Do we need a lock for the table?
>>
>
> And kvm_add_irq_route/kvm_del_irq_route should be generic used, how about
> transfer a kvm_irq_routing_entry as parameter?
>

These structures + selectors + unions are clumsy. For libkvm, I'd
prefer adding kvm_add_msi() and kvm_del_msi().

--
error compiling committee.c: too many arguments to function