From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH 2/5] virtio-net: Add a virtqueue for control commands from the guest Date: Wed, 14 Jan 2009 09:57:28 -0700 Message-ID: <1231952248.7109.341.camel@lappy> References: <1231881831.9095.192.camel@bling> <1231928115.4944.293.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm , qemu-devel To: Mark McLoughlin Return-path: Received: from g4t0014.houston.hp.com ([15.201.24.17]:41751 "EHLO g4t0014.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757709AbZANQ45 (ORCPT ); Wed, 14 Jan 2009 11:56:57 -0500 In-Reply-To: <1231928115.4944.293.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2009-01-14 at 10:15 +0000, Mark McLoughlin wrote: > On Tue, 2009-01-13 at 14:23 -0700, Alex Williamson wrote: > > + > > + ctrl = (void *)elem.out_sg[0].iov_base; > > + status = (void *)elem.in_sg[elem.in_num - 1].iov_base; > > These casts aren't needed - iov_base is a void pointer. Thanks Alex -- Alex Williamson HP Open Source & Linux Org.