From: Mark McLoughlin <markmc@redhat.com>
To: avi@redhat.com
Cc: kvm@vger.kernel.org, Mark McLoughlin <markmc@redhat.com>
Subject: [PATCH 05/18] kvm: qemu: Fix virtio_blk_init() calls
Date: Thu, 15 Jan 2009 13:47:29 +0000 [thread overview]
Message-ID: <1232027262-21487-5-git-send-email-markmc@redhat.com> (raw)
In-Reply-To: <1232027262-21487-4-git-send-email-markmc@redhat.com>
This QEMU commit:
pci: virtio: use pci id defines (Gerd Hoffman)
removed the vendor/device id parameters from virtio_blk_init().
Fixes:
qemu/hw/device-hotplug.c: In function ‘qemu_system_hot_add_storage’:
qemu/hw/device-hotplug.c:165: warning: implicit declaration of function ‘virtio_blk_init’
qemu/hw/device-hotplug.c:166: warning: assignment makes pointer from integer without a cast
(Note: the ia64 fix is untested)
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
---
qemu/hw/device-hotplug.c | 4 ++--
qemu/hw/ipf.c | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/qemu/hw/device-hotplug.c b/qemu/hw/device-hotplug.c
index 56172e1..d8f0fcc 100644
--- a/qemu/hw/device-hotplug.c
+++ b/qemu/hw/device-hotplug.c
@@ -8,6 +8,7 @@
#include "block_int.h"
#include "device-assignment.h"
#include "config.h"
+#include "virtio-blk.h"
#define PCI_BASE_CLASS_STORAGE 0x01
#define PCI_BASE_CLASS_NETWORK 0x02
@@ -162,8 +163,7 @@ static PCIDevice *qemu_system_hot_add_storage(const char *opts, int bus_nr)
drives_table[drive_idx].unit);
break;
case IF_VIRTIO:
- opaque = virtio_blk_init (pci_bus, 0x1AF4, 0x1001,
- drives_table[drive_idx].bdrv);
+ opaque = virtio_blk_init(pci_bus, drives_table[drive_idx].bdrv);
break;
default:
term_printf ("type %s not a hotpluggable PCI device.\n", buf);
diff --git a/qemu/hw/ipf.c b/qemu/hw/ipf.c
index 74a7703..9654494 100644
--- a/qemu/hw/ipf.c
+++ b/qemu/hw/ipf.c
@@ -39,6 +39,7 @@
#include "ia64intrin.h"
#include <unistd.h>
#include "device-assignment.h"
+#include "virtio-blk.h"
#include "qemu-kvm.h"
@@ -625,7 +626,7 @@ static void ipf_init1(ram_addr_t ram_size, int vga_ram_size,
int unit_id = 0;
while ((index = drive_get_index(IF_VIRTIO, 0, unit_id)) != -1) {
- virtio_blk_init(pci_bus, 0x1AF4, 0x1001, drives_table[index].bdrv);
+ virtio_blk_init(pci_bus, drives_table[index].bdrv);
unit_id++;
}
}
--
1.6.0.6
next prev parent reply other threads:[~2009-01-15 13:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 13:47 [PATCH 01/18] kvm: qemu: fix the prototype of virtio_net_init() Mark McLoughlin
2009-01-15 13:47 ` [PATCH 02/18] kvm: qemu: make qemu_alloc_physram() and alloc_mem_area() static Mark McLoughlin
2009-01-15 13:47 ` [PATCH 03/18] kvm: qemu: kill some redundant declarations Mark McLoughlin
2009-01-15 13:47 ` [PATCH 04/18] kvm: qemu: make lsi_scsi_uninit() static Mark McLoughlin
2009-01-15 13:47 ` Mark McLoughlin [this message]
2009-01-15 13:47 ` [PATCH 06/18] kvm: qemu: device-assignment: don't use libkvm's private get_slot() Mark McLoughlin
2009-01-15 13:47 ` [PATCH 07/18] kvm: libkvm: make get_slot() and co. static Mark McLoughlin
2009-01-15 13:47 ` [PATCH 08/18] kvm: qemu: device-assignment: add kvm_add_ioperm_data() prototype Mark McLoughlin
2009-01-15 13:47 ` [PATCH 09/18] kvm: qemu: device-assignment: add assigned_dev_update_irq() prototype Mark McLoughlin
2009-01-15 13:47 ` [PATCH 10/18] kvm: qemu: device-assignment: fix ROM writing Mark McLoughlin
2009-01-15 13:47 ` [PATCH 11/18] kvm: qemu: kill unused variable Mark McLoughlin
2009-01-15 13:47 ` [PATCH 12/18] kvm: qemu: kill redundant declarion of perror() Mark McLoughlin
2009-01-15 13:47 ` [PATCH 13/18] kvm: qemu: kill redundant declaration of smp_cpus and vm_running Mark McLoughlin
2009-01-15 13:47 ` [PATCH 14/18] kvm: qemu: make qemu_kvm_system_reset() static Mark McLoughlin
2009-01-15 13:47 ` [PATCH 15/18] kvm: qemu: kill unused variable in kvm_init_vcpu() Mark McLoughlin
2009-01-15 13:47 ` [PATCH 16/18] kvm: qemu: make another couple of functions static Mark McLoughlin
2009-01-15 13:47 ` [PATCH 17/18] kvm: qemu: fix update_vbios_real_tpr declaration Mark McLoughlin
2009-01-15 13:47 ` [PATCH 18/18] kvm: qemu: kill unused variable in enable_vapic() Mark McLoughlin
2009-01-15 13:54 ` [PATCH 10/18] kvm: qemu: device-assignment: fix ROM writing Avi Kivity
2009-01-15 14:24 ` Mark McLoughlin
2009-01-15 14:35 ` Avi Kivity
2009-01-15 13:58 ` [PATCH 01/18] kvm: qemu: fix the prototype of virtio_net_init() Avi Kivity
2009-01-15 14:28 ` Mark McLoughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232027262-21487-5-git-send-email-markmc@redhat.com \
--to=markmc@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox