From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark McLoughlin <markmc@redhat.com>
Subject: Re: [PATCH 01/18] kvm: qemu: fix the prototype of virtio_net_init()
Date: Thu, 15 Jan 2009 14:28:43 +0000
Message-ID: <1232029723.5205.26.camel@localhost.localdomain>
References: <1232027262-21487-1-git-send-email-markmc@redhat.com>
	 <496F40F0.7090502@redhat.com>
Reply-To: Mark McLoughlin <markmc@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:53016 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758190AbZAOO2r (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 15 Jan 2009 09:28:47 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0FESkmD014631
	for <kvm@vger.kernel.org>; Thu, 15 Jan 2009 09:28:46 -0500
In-Reply-To: <496F40F0.7090502@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, 2009-01-15 at 15:58 +0200, Avi Kivity wrote:
> Mark McLoughlin wrote:
> > NIC init functions don't return a PCIDevice pointer in upstream QEMU
> > but they do in KVM for hotplug.
> >
> > Fixes:
> >
> >   qemu/hw/pci.c:740: warning: initialization from incompatible pointer type
> >
> >   
> 
> I should have caught this while merging, argh.
> 
> Applied all patches except #10, thanks.  If qemu gains a --developer 
> option which enables -Werror (and if we're warning clean), I promise to 
> use it.

Yeah, it has --enable-werror, but it's not quite warning clean yet (tcg
and slirp AFAIR)

There's still a bunch more warnings in kvm-userspace that aren't in
upstream qemu - I just quickly fixed the obvious ones.

Cheers,
Mark.