From: Mark McLoughlin <markmc@redhat.com>
To: Alex Williamson <alex.williamson@hp.com>
Cc: Avi Kivity <avi@redhat.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] virtio-net: Fix save/load
Date: Thu, 15 Jan 2009 18:51:56 +0000 [thread overview]
Message-ID: <1232045516.24287.6.camel@localhost.localdomain> (raw)
In-Reply-To: <1232044799.20605.22.camel@bling>
On Thu, 2009-01-15 at 11:39 -0700, Alex Williamson wrote:
> > version_id)
> > > {
> > > VirtIONet *n = opaque;
> > >
> > > - if (version_id != 2)
> > > + if (version_id < 3 || version_id > VIRTIO_NET_VM_VERSION)
> >
> > This bit isn't right - how can this code load e.g. version 4?
>
> It can't. There's no way to load a save image for a version_id
> greater
> than VIRTIO_NET_VM_VERSION, because we don't know how much data to pop
> off or what state we'd be missing. We can only load older save images
> on equal or newer versions of qemu. As far as know... Thanks,
Yes, I read the code wrong :)
Cheers,
Mark.
next prev parent reply other threads:[~2009-01-15 18:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 18:05 [PATCH] virtio-net: Fix save/load Alex Williamson
2009-01-15 18:21 ` Mark McLoughlin
2009-01-15 18:39 ` Alex Williamson
2009-01-15 18:51 ` Mark McLoughlin [this message]
2009-05-06 7:21 ` Avi Kivity
2009-05-06 13:46 ` Anthony Liguori
2009-05-06 14:09 ` Avi Kivity
2009-05-06 16:01 ` Alex Williamson
2009-05-07 10:11 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232045516.24287.6.camel@localhost.localdomain \
--to=markmc@redhat.com \
--cc=alex.williamson@hp.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox