From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark McLoughlin <markmc@redhat.com>
Subject: Re: [PATCH] virtio-net: Fix save/load
Date: Thu, 15 Jan 2009 18:51:56 +0000
Message-ID: <1232045516.24287.6.camel@localhost.localdomain>
References: <1232042731.20605.9.camel@bling>
	 <1232043670.24287.5.camel@localhost.localdomain>
	 <1232044799.20605.22.camel@bling>
Reply-To: Mark McLoughlin <markmc@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, kvm-devel <kvm@vger.kernel.org>
To: Alex Williamson <alex.williamson@hp.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:50816 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753219AbZAOSwC (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 15 Jan 2009 13:52:02 -0500
In-Reply-To: <1232044799.20605.22.camel@bling>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, 2009-01-15 at 11:39 -0700, Alex Williamson wrote:
> > version_id)
> > >  {
> > >      VirtIONet *n = opaque;
> > >  
> > > -    if (version_id != 2)
> > > +    if (version_id < 3 || version_id > VIRTIO_NET_VM_VERSION)
> > 
> > This bit isn't right - how can this code load e.g. version 4?
> 
> It can't.  There's no way to load a save image for a version_id
> greater
> than VIRTIO_NET_VM_VERSION, because we don't know how much data to pop
> off or what state we'd be missing.  We can only load older save images
> on equal or newer versions of qemu.  As far as know...  Thanks,

Yes, I read the code wrong :)

Cheers,
Mark.