From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alok Kataria <akataria@vmware.com>
Subject: Re: [PATCH 1/2] show hypervisor information on cpuinfo
Date: Thu, 05 Feb 2009 10:53:07 -0800
Message-ID: <1233859987.29693.9.camel@alok-dev1>
References: <1233859341-10419-1-git-send-email-glommer@redhat.com>
	 <1233859341-10419-2-git-send-email-glommer@redhat.com>
Reply-To: akataria@vmware.com
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mingo@elte.hu" <mingo@elte.hu>, "avi@redhat.com" <avi@redhat.com>,
	Glauber Costa <gcosta@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from smtp-outbound-1.vmware.com ([65.115.85.69]:33155 "EHLO
	smtp-outbound-1.vmware.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752326AbZBESxJ (ORCPT
	<rfc822;kvm@vger.kernel.org>); Thu, 5 Feb 2009 13:53:09 -0500
In-Reply-To: <1233859341-10419-2-git-send-email-glommer@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

I am all for it.

Just one nit, below.

>  
> +char * __cpuinit hypervisor_str(struct cpuinfo_x86 *c)
> +{
> +	if (c->x86_hyper_vendor == X86_HYPER_VENDOR_VMWARE)
> +		return "VMWare";

Better to have "VMware" string instead.

Thanks,
Alok