* [PATCH 3/3] [RESEND] kvm: qemu: fix double removal of assigned device
@ 2009-02-06 8:58 Han, Weidong
2009-02-06 10:16 ` Mark McLoughlin
0 siblings, 1 reply; 2+ messages in thread
From: Han, Weidong @ 2009-02-06 8:58 UTC (permalink / raw)
To: 'Avi Kivity'; +Cc: 'kvm@vger.kernel.org'
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
free_assigned_device removes the assigned device from the
list adev_head, needn't remove it in assigned_dev_update_irqs.
Signed-off-by: Weidong Han <weidong.han@intel.com>
---
qemu/hw/device-assignment.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
index 82ff00a..e6d2352 100644
--- a/qemu/hw/device-assignment.c
+++ b/qemu/hw/device-assignment.c
@@ -522,7 +522,6 @@ void assigned_dev_update_irqs()
adev->name, strerror(-r));
fprintf(stderr, "Perhaps you are assigning a device "
"that shares an IRQ with another device?\n");
- LIST_REMOVE(adev, next);
free_assigned_device(adev);
adev = next;
continue;
--
1.6.0.4
[-- Attachment #2: 0003-kvm-qemu-fix-double-removal-of-assigned-device.patch --]
[-- Type: application/octet-stream, Size: 1055 bytes --]
From 0c86ca498f18a0679f2236e7b23c2efb5e921a17 Mon Sep 17 00:00:00 2001
From: Weidong Han <weidong.han@intel.com>
Date: Fri, 6 Feb 2009 16:43:10 +0800
Subject: [PATCH] kvm: qemu: fix double removal of assigned device
free_assigned_device removes the assigned device from the
list adev_head, needn't remove it in assigned_dev_update_irqs.
Signed-off-by: Weidong Han <weidong.han@intel.com>
---
qemu/hw/device-assignment.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
index 82ff00a..e6d2352 100644
--- a/qemu/hw/device-assignment.c
+++ b/qemu/hw/device-assignment.c
@@ -522,7 +522,6 @@ void assigned_dev_update_irqs()
adev->name, strerror(-r));
fprintf(stderr, "Perhaps you are assigning a device "
"that shares an IRQ with another device?\n");
- LIST_REMOVE(adev, next);
free_assigned_device(adev);
adev = next;
continue;
--
1.6.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] [RESEND] kvm: qemu: fix double removal of assigned device
2009-02-06 8:58 [PATCH 3/3] [RESEND] kvm: qemu: fix double removal of assigned device Han, Weidong
@ 2009-02-06 10:16 ` Mark McLoughlin
0 siblings, 0 replies; 2+ messages in thread
From: Mark McLoughlin @ 2009-02-06 10:16 UTC (permalink / raw)
To: Han, Weidong; +Cc: 'Avi Kivity', 'kvm@vger.kernel.org'
On Fri, 2009-02-06 at 16:58 +0800, Han, Weidong wrote:
> free_assigned_device removes the assigned device from the
> list adev_head, needn't remove it in assigned_dev_update_irqs.
>
> Signed-off-by: Weidong Han <weidong.han@intel.com>
Acked-by: Mark McLoughlin <markmc@redhat.com>
Cheers,
Mark.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-06 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-06 8:58 [PATCH 3/3] [RESEND] kvm: qemu: fix double removal of assigned device Han, Weidong
2009-02-06 10:16 ` Mark McLoughlin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox