From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark McLoughlin Subject: Re: [PATCH 0/3][v2] Fix racy in kvm_free_assigned_irq Date: Fri, 06 Feb 2009 10:49:18 +0000 Message-ID: <1233917358.27709.23.camel@blaa> References: <1231207383-22625-1-git-send-email-sheng@linux.intel.com> <49632297.5000008@redhat.com> Reply-To: Mark McLoughlin Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Sheng Yang , Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53639 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753804AbZBFKtW (ORCPT ); Fri, 6 Feb 2009 05:49:22 -0500 In-Reply-To: <49632297.5000008@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 2009-01-06 at 11:21 +0200, Avi Kivity wrote: > Sheng Yang wrote: > > Hi Avi > > > > I just add a comment for kvm_free_assigned_irq(). The other things are all > > the same as the patchset you have reviewed. > > > > Applied, thanks. These would make sense for 2.6.29, right? I just saw the oops below when I killed a busy guest with an assigned device, and it looks like it might be related. Cheers, Mark. BUG: unable to handle kernel paging request at 0000000000200200 IP: [] list_del+0x10/0x85 PGD 171c82067 PUD 1741d8067 PMD 0 Oops: 0000 [#1] SMP last sysfs file: /sys/devices/pci0000:00/0000:00:1e.0/0000:01:00.0/local_cpus CPU 1 Modules linked in: fuse i915 drm i2c_algo_bit ipt_MASQUERADE iptable_nat nf_nat sco bnep l2cap bluetooth sunrpc bridge stp xt_physdev ip6t_REJECT nf_conntrack_ipv6 ip6table_filter ip6_tables ipv6 dm_multipath kvm_intel kvm uinput snd_hda_codec_idt snd_hda_intel snd_hda_codec snd_hwdep snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_pcm_oss snd_mixer_oss snd_pcm snd_timer snd e1000e i2c_i801 soundcore snd_page_alloc i2c_core pcspkr joydev ata_generic pata_acpi [last unloaded: freq_table] Pid: 17, comm: events/1 Tainted: G W 2.6.29-rc3 #30 RIP: 0010:[] [] list_del+0x10/0x85 RSP: 0018:ffff88017e165dc0 EFLAGS: 00010286 RAX: 0000000000200200 RBX: ffff8801628eca98 RCX: 0000000000000000 RDX: 0000000000050001 RSI: ffffffffa010ab98 RDI: ffff8801628eca98 RBP: ffff88017e165dd0 R08: 0000000000000002 R09: 0000000000000000 R10: 0000000000000000 R11: ffff88017e081140 R12: ffff880164b01c80 R13: ffff88016c1a91a8 R14: ffff88017e165e70 R15: 0000000000000006 FS: 0000000000000000(0000) GS:ffff88017e07b000(0000) knlGS:0000000000000000 CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b CR2: 0000000000200200 CR3: 0000000171c0c000 CR4: 00000000000426e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Process events/1 (pid: 17, threadinfo ffff88017e164000, task ffff88017e180000) Stack: ffffffffa010ab98 ffff8801628ec000 ffff88017e165df0 ffffffffa010aba4 ffff88016c1a91b0 ffff88016c1a9188 ffff88017e165e40 ffffffffa010b93a ffff88017e160148 000000007e160148 ffff88017e165e70 ffff88016c1a91b0 Call Trace: [] ? kvm_put_kvm+0x32/0xac [kvm] [] kvm_put_kvm+0x3e/0xac [kvm] Message from [] kvm_assigned_dev_interrupt_work_handler+0x18d/0x19c [kvm] [] run_workqueue+0x103/0x20a [] ? run_workqueue+0xb1/0x20a [] ? kvm_assigned_dev_interrupt_work_handler+0x0/0x19c [kvm] [] worker_thread+0xe0/0xf1 [] ? autoremove_wake_function+0x0/0x38 [] ? worker_thread+0x0/0xf1 [] kthread+0x49/0x76 [] child_rip+0xa/0x20 [] ? _spin_unlock_irq+0x2b/0x37 [] ? trace_hardirqs_on+0xd/0xf [] ? restore_args+0x0/0x30 [] ? kthread+0x0/0x76 [] ? child_rip+0x0/0x20 Code: 7c 24 18 e8 98 00 00 00 4c 89 ef e8 7b fe ff ff 59 5b 41 5c 41 5d c9 c3 90 90 90 55 48 89 e5 53 48 89 fb 48 83 ec 08 48 8b 47 08 <48> 8b 00 48 39 f8 74 20 49 89 c0 48 89 f9 48 c7 c2 2a 7b 4d 81 RIP [] list_del+0x10/0x85 RSP CR2: 0000000000200200