From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH][RFC] qemu:virtio-net: Use TUNSETTXFILTER for MAC filtering Date: Fri, 06 Feb 2009 11:06:03 -0700 Message-ID: <1233943563.7026.1345.camel@lappy> References: <20090206044853.3116.46699.stgit@kvm.aw> <498C4258.3060502@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from g1t0027.austin.hp.com ([15.216.28.34]:23854 "EHLO g1t0027.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754131AbZBFSFZ (ORCPT ); Fri, 6 Feb 2009 13:05:25 -0500 In-Reply-To: <498C4258.3060502@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 2009-02-06 at 07:59 -0600, Anthony Liguori wrote: > > Instead of having each network device do it's own filtering if the VLAN > doesn't support it, I think we should move the software filtering to the > VLAN layer so that we aren't duplicating code in each network device. > > Also, instead of using IFF_xxx, I think we should introduce our own > flags. net/if.h doesn't exist on Windows most likely. Thanks for the comments, I'll look into making these changes. Alex