From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH 4/4] qemu:e1000: Add support for qemu_vlan_rxfilter Date: Wed, 11 Feb 2009 08:11:01 -0700 Message-ID: <1234365061.7026.1511.camel@lappy> References: <20090210212841.9760.96780.stgit@kvm.aw> <20090210212902.9760.6747.stgit@kvm.aw> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: qemu-devel@nongnu.org Return-path: Received: from g4t0014.houston.hp.com ([15.201.24.17]:14406 "EHLO g4t0014.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753980AbZBKPKV (ORCPT ); Wed, 11 Feb 2009 10:10:21 -0500 In-Reply-To: <20090210212902.9760.6747.stgit@kvm.aw> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 2009-02-10 at 14:29 -0700, Alex Williamson wrote: > Make use of qemu_vlan_rxfilter so that we can filter at a lower > level. We implement callbacks for devices being added and removed > so that we can fall back to our own filtering or make another attempt > to push filtering off to someone else. Hmm, I've thought of a bug in this patch, I'm not accounting for the multicast hash e1000 can use for imperfect filtering. I'll need to rework this one, maybe skip the tap filter if the hash is in use. This is independent of the other patches though. Thanks, Alex