From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark McLoughlin <markmc@redhat.com>
Subject: Re: [PATCH 1/4] kvm: define KVM_CAP_DEVICE_DEASSIGNMENT
Date: Wed, 11 Feb 2009 18:58:55 +0000
Message-ID: <1234378735.14052.223.camel@blaa>
References: <715D42877B251141A38726ABF5CABF2C01959AF3FF@pdsmsx503.ccr.corp.intel.com>
Reply-To: Mark McLoughlin <markmc@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: "'Avi Kivity'" <avi@redhat.com>,
	"'kvm@vger.kernel.org'" <kvm@vger.kernel.org>
To: "Han, Weidong" <weidong.han@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:52289 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757270AbZBKS7A (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 11 Feb 2009 13:59:00 -0500
In-Reply-To: <715D42877B251141A38726ABF5CABF2C01959AF3FF@pdsmsx503.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, 2009-02-10 at 20:40 +0800, Han, Weidong wrote:
> define KVM_CAP_DEVICE_DEASSIGNMENT and KVM_DEASSIGN_PCI_DEVICE
> for device deassignment.

Should add a pointer to the commit which added this ioctl:

  commit 0a920356748df4fb06e86c21c23d2ed6d31d37ad
  Author: Weidong Han <weidong.han@intel.com>
  Date:   Tue Dec 2 21:24:23 2008 +0800

    KVM: support device deassignment
    
    Support device deassignment, it can be used in device hotplug.
    
    Signed-off-by: Weidong Han <weidong.han@intel.com>
    Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>

> Signed-off-by: Weidong Han <weidong.han@intel.com>
> ---
>  include/linux/kvm.h |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/kvm.h b/include/linux/kvm.h
> index 869462c..02dfb1b 100644
> --- a/include/linux/kvm.h
> +++ b/include/linux/kvm.h
> @@ -402,6 +402,9 @@ struct kvm_trace_rec {
>  #ifdef __KVM_HAVE_IOAPIC
>  #define KVM_CAP_IRQ_ROUTING 25
>  #endif
> +#ifdef __KVM_HAVE_DEVICE_ASSIGNMENT
> +#define KVM_CAP_DEVICE_DEASSIGNMENT 26
> +#endif
>  
>  #ifdef KVM_CAP_IRQ_ROUTING
>  
> @@ -466,6 +469,8 @@ struct kvm_irq_routing {
>  #define KVM_ASSIGN_IRQ _IOR(KVMIO, 0x70, \
>  			    struct kvm_assigned_irq)
>  #define KVM_REINJECT_CONTROL      _IO(KVMIO, 0x71)
> +#define KVM_DEASSIGN_PCI_DEVICE _IOR(KVMIO, 0x72, \
> +				     struct kvm_assigned_pci_dev)
>  

Looks good to me, but I wonder why we never used 0x6b-0x6f?

Acked-by: Mark McLoughlin <markmc@redhat.com>

Cheers,
Mark.