Re: [PATCH 2/4] kvm: change a loglevel in kvm_vm_ioctl_deassign_device

[Mark McLoughlin <markmc@redhat.com>]

On Tue, 2009-02-10 at 20:40 +0800, Han, Weidong wrote:
> change from KERN_INFO to KERN_WARNING to prompt users when
> deassign an unassigned device
> 
> Signed-off-by: Weidong Han <weidong.han@intel.com>
> ---
>  virt/kvm/kvm_main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index ef52622..03f9807 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -568,7 +568,7 @@ static int kvm_vm_ioctl_deassign_device(struct kvm *kvm,
>  	match = kvm_find_assigned_dev(&kvm->arch.assigned_dev_head,
>  				      assigned_dev->assigned_dev_id);
>  	if (!match) {
> -		printk(KERN_INFO "%s: device hasn't been assigned before, "
> +		printk(KERN_WARNING "%s: device hasn't been assigned before, "
>  		  "so cannot be deassigned\n", __func__);

Personally, I'd drop the printk() - the calling program has passed an
invalid device ID and we've returned -EINVAL, I think we should be
silent in such cases and let the app do the error handling.

Cheers,
Mark.