From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark McLoughlin Subject: Re: [PATCH 2/4] kvm: change a loglevel in kvm_vm_ioctl_deassign_device Date: Wed, 11 Feb 2009 18:59:07 +0000 Message-ID: <1234378747.14052.224.camel@blaa> References: <715D42877B251141A38726ABF5CABF2C01959AF400@pdsmsx503.ccr.corp.intel.com> Reply-To: Mark McLoughlin Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "'Avi Kivity'" , "'kvm@vger.kernel.org'" To: "Han, Weidong" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:52298 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756781AbZBKS7M (ORCPT ); Wed, 11 Feb 2009 13:59:12 -0500 In-Reply-To: <715D42877B251141A38726ABF5CABF2C01959AF400@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 2009-02-10 at 20:40 +0800, Han, Weidong wrote: > change from KERN_INFO to KERN_WARNING to prompt users when > deassign an unassigned device > > Signed-off-by: Weidong Han > --- > virt/kvm/kvm_main.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index ef52622..03f9807 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -568,7 +568,7 @@ static int kvm_vm_ioctl_deassign_device(struct kvm *kvm, > match = kvm_find_assigned_dev(&kvm->arch.assigned_dev_head, > assigned_dev->assigned_dev_id); > if (!match) { > - printk(KERN_INFO "%s: device hasn't been assigned before, " > + printk(KERN_WARNING "%s: device hasn't been assigned before, " > "so cannot be deassigned\n", __func__); Personally, I'd drop the printk() - the calling program has passed an invalid device ID and we've returned -EINVAL, I think we should be silent in such cases and let the app do the error handling. Cheers, Mark.