From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark McLoughlin Subject: Re: [PATCH 0/4] qemu: TAP filtering support Date: Wed, 11 Feb 2009 19:31:18 +0000 Message-ID: <1234380678.14052.238.camel@blaa> References: <20090210212841.9760.96780.stgit@kvm.aw> Reply-To: Mark McLoughlin Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Alex Williamson Return-path: Received: from mx2.redhat.com ([66.187.237.31]:37948 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755917AbZBKTbY (ORCPT ); Wed, 11 Feb 2009 14:31:24 -0500 In-Reply-To: <20090210212841.9760.96780.stgit@kvm.aw> Sender: kvm-owner@vger.kernel.org List-ID: Hi Alex, Just had a quick looked over these and they seem pretty good, but some broad comments: - The logic around "is this a NIC+TAP pair?" would be good to have a better API around. We need this to merge virtio GSO support too. Anthony had some ideas here. - I think you could keep the client_added()/removed() logic in net.c and things would be a lot cleaner. I think you just want to trigger a reload of the filter, right? So a "reload this filter" callback to qemu_vlan_rxfilter() might do it. - What do we need rxfilter=on|off on the command line for? Cheers, Mark.