From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@hp.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for
 qemu_vlan_rxfilter
Date: Thu, 12 Feb 2009 09:36:47 -0700
Message-ID: <1234456607.25178.177.camel@bling>
References: <20090210212841.9760.96780.stgit@kvm.aw>
	 <20090210212857.9760.31288.stgit@kvm.aw>
	 <200902121626.58977.paul@codesourcery.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
To: Paul Brook <paul@codesourcery.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from g1t0028.austin.hp.com ([15.216.28.35]:3045 "EHLO
	g1t0028.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751339AbZBLQgv (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 12 Feb 2009 11:36:51 -0500
In-Reply-To: <200902121626.58977.paul@codesourcery.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, 2009-02-12 at 16:26 +0000, Paul Brook wrote:
> > +static void virtio_net_vlan_client_added(void *opaque)
> >...
> > +static void virtio_net_vlan_client_removed(void *opaque)
> 
> Why are these two different?
> 
> It looks like what you really want is a callback for "Something changed,
> and you need to reset your MAC filter."

I think we'd end up with a race if we only had one callback.  For
instance if "change" was the result of a vlan client being removed, the
tap would clear the filter and the nic would try to install a filter.
The results would be different based on the calling order.

Alex