public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] use KVM_UPSTREAM for ppc.
@ 2009-02-13 18:07 Glauber Costa
  2009-02-13 19:13 ` Hollis Blanchard
  2009-02-16 23:57 ` Dustin Kirkland
  0 siblings, 2 replies; 3+ messages in thread
From: Glauber Costa @ 2009-02-13 18:07 UTC (permalink / raw)
  To: kvm; +Cc: qemu-devel, avi, hollisb

ppc should compile with upstream qemu code, so, put these
defines in ppc specific code that references kvm functions.

We don put them in config.h in this case, since there are
files (like vl.c) that includes both kvm.h and qemu-kvm.h,
and would break compilation.

Signed-off-by: Glauber Costa <glommer@redhat.com>
---
 qemu/hw/ppc440.c         |    1 +
 qemu/hw/ppc440_bamboo.c  |    1 +
 qemu/target-ppc/helper.c |    1 +
 3 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/qemu/hw/ppc440.c b/qemu/hw/ppc440.c
index 00d82e4..164c326 100644
--- a/qemu/hw/ppc440.c
+++ b/qemu/hw/ppc440.c
@@ -18,6 +18,7 @@
 #include "ppc440.h"
 #include "ppc405.h"
 #include "sysemu.h"
+#define KVM_UPSTREAM
 #include "kvm.h"
 
 #define PPC440EP_PCI_CONFIG     0xeec00000
diff --git a/qemu/hw/ppc440_bamboo.c b/qemu/hw/ppc440_bamboo.c
index fbd447c..60ddaf4 100644
--- a/qemu/hw/ppc440_bamboo.c
+++ b/qemu/hw/ppc440_bamboo.c
@@ -21,6 +21,7 @@
 #include "boards.h"
 #include "sysemu.h"
 #include "ppc440.h"
+#define KVM_UPSTREAM
 #include "kvm.h"
 #include "kvm_ppc.h"
 #include "device_tree.h"
diff --git a/qemu/target-ppc/helper.c b/qemu/target-ppc/helper.c
index fc62a63..d49acaf 100644
--- a/qemu/target-ppc/helper.c
+++ b/qemu/target-ppc/helper.c
@@ -29,6 +29,7 @@
 #include "exec-all.h"
 #include "helper_regs.h"
 #include "qemu-common.h"
+#define KVM_UPSTREAM
 #include "kvm.h"
 
 //#define DEBUG_MMU
-- 
1.5.6.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] use KVM_UPSTREAM for ppc.
  2009-02-13 18:07 [PATCH] use KVM_UPSTREAM for ppc Glauber Costa
@ 2009-02-13 19:13 ` Hollis Blanchard
  2009-02-16 23:57 ` Dustin Kirkland
  1 sibling, 0 replies; 3+ messages in thread
From: Hollis Blanchard @ 2009-02-13 19:13 UTC (permalink / raw)
  To: Glauber Costa; +Cc: kvm, qemu-devel, avi

On Fri, 2009-02-13 at 13:07 -0500, Glauber Costa wrote:
> ppc should compile with upstream qemu code, so, put these
> defines in ppc specific code that references kvm functions.
> 
> We don put them in config.h in this case, since there are
> files (like vl.c) that includes both kvm.h and qemu-kvm.h,
> and would break compilation.
> 
> Signed-off-by: Glauber Costa <glommer@redhat.com>

I actually haven't tried to build kvm-userspace for PPC since we got
upstream qemu working...

I'm a little confused though, because it doesn't look like even x86 is
using this?

-- 
Hollis Blanchard
IBM Linux Technology Center


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] use KVM_UPSTREAM for ppc.
  2009-02-13 18:07 [PATCH] use KVM_UPSTREAM for ppc Glauber Costa
  2009-02-13 19:13 ` Hollis Blanchard
@ 2009-02-16 23:57 ` Dustin Kirkland
  1 sibling, 0 replies; 3+ messages in thread
From: Dustin Kirkland @ 2009-02-16 23:57 UTC (permalink / raw)
  To: Glauber Costa; +Cc: kvm, qemu-devel, avi, hollisb

On 2/13/09, Glauber Costa <glommer@redhat.com> wrote:
> ppc should compile with upstream qemu code, so, put these
>  defines in ppc specific code that references kvm functions.
>
>  We don put them in config.h in this case, since there are
>  files (like vl.c) that includes both kvm.h and qemu-kvm.h,
>  and would break compilation.

Ack.

This patch is required for Ubuntu packaging of kvm-84.  Otherwise, the
compilation is broken.

Thanks for this.

:-Dustin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-02-16 23:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-13 18:07 [PATCH] use KVM_UPSTREAM for ppc Glauber Costa
2009-02-13 19:13 ` Hollis Blanchard
2009-02-16 23:57 ` Dustin Kirkland

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox