Re: [PATCH v10 4/7] PCI: add SR-IOV API for Physical Function driver

Randy Dunlap
2009-03-06T21:48:33Z

Matthew Wilcox wrote:
> On Fri, Feb 20, 2009 at 02:54:45PM +0800, Yu Zhao wrote:
>
>> + if (nres != iov->nres) {
>> + dev_err(&dev->dev, "no enough MMIO for SR-IOV\n");
>> + return -ENOMEM;
>> + }

"not enough MMIO BARs for SR-IOV"
or
"not enough MMIO resources for SR-IOV"
or
"too few MMIO BARs for SR-IOV"
?

> Randy, can you help us out with better wording here?
>
>> + dev_err(&dev->dev, "no enough bus range for SR-IOV\n");
>
> and here.

"SR-IOV: bus number too large"
or
"SR-IOV: bus number out of range"
or
"SR-IOV: cannot allocate valid bus number"
?

>> + if (iov->link != dev->devfn) {
>> + rc = -ENODEV;
>> + list_for_each_entry(link, &dev->bus->devices, bus_list) {
>> + if (link->sriov && link->devfn == iov->link)
>> + rc = sysfs_create_link(&iov->dev.kobj,
>> + &link->dev.kobj, "dep_link");