From: Sheng Yang <sheng@linux.intel.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, Sheng Yang <sheng@linux.intel.com>
Subject: [PATCH 1/3] kvm: fix irq 0 assignment
Date: Wed, 4 Mar 2009 15:54:27 +0800 [thread overview]
Message-ID: <1236153269-8825-2-git-send-email-sheng@linux.intel.com> (raw)
In-Reply-To: <1236153269-8825-1-git-send-email-sheng@linux.intel.com>
Shouldn't update assigned irq if host irq is 0, which means uninitialized
or don't support INTx.
Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
qemu/hw/device-assignment.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
index 32fba2a..7f9c789 100644
--- a/qemu/hw/device-assignment.c
+++ b/qemu/hw/device-assignment.c
@@ -574,6 +574,10 @@ static int assign_irq(AssignedDevInfo *adev)
AssignedDevice *dev = adev->assigned_dev;
int irq, r = 0;
+ /* irq 0 means uninitialized */
+ if (dev->real_device.irq == 0)
+ return 0;
+
irq = pci_map_irq(&dev->dev, dev->intpin);
irq = piix_get_irq(irq);
--
1.5.4.5
next prev parent reply other threads:[~2009-03-04 7:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 7:54 [PATCH 0/3] Enable SRIOV with KVM Sheng Yang
2009-03-04 7:54 ` Sheng Yang [this message]
2009-03-04 9:53 ` [PATCH 1/3] kvm: fix irq 0 assignment Chris Wedgwood
2009-03-04 9:58 ` Sheng Yang
2009-03-04 10:02 ` Sheng Yang
2009-03-04 19:30 ` Marcelo Tosatti
2009-03-04 19:41 ` Chris Wright
2009-03-05 2:47 ` Sheng Yang
2009-03-04 7:54 ` [PATCH 2/3] KVM: Fill config with correct VID/DID Sheng Yang
2009-03-04 7:54 ` [PATCH 3/3] kvm: emulate command register for SRIOV virtual function Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236153269-8825-2-git-send-email-sheng@linux.intel.com \
--to=sheng@linux.intel.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox