From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: [PATCH 14/16] kvm: fix interrupt pin 0 assignment Date: Tue, 17 Mar 2009 11:50:15 +0800 Message-ID: <1237261817-27955-15-git-send-email-sheng@linux.intel.com> References: <1237261817-27955-1-git-send-email-sheng@linux.intel.com> Cc: kvm@vger.kernel.org, Sheng Yang To: Avi Kivity , Marcelo Tosatti , Anthony Liguori Return-path: Received: from mga01.intel.com ([192.55.52.88]:20459 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762545AbZCQDuZ (ORCPT ); Mon, 16 Mar 2009 23:50:25 -0400 In-Reply-To: <1237261817-27955-1-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Shouldn't update assigned irq if assigned device's interrupt pin is 0, which means uninitialized or don't support INTx. Signed-off-by: Sheng Yang --- qemu/hw/device-assignment.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c index b0b90c1..411ccc5 100644 --- a/qemu/hw/device-assignment.c +++ b/qemu/hw/device-assignment.c @@ -590,6 +590,10 @@ static int assign_irq(AssignedDevInfo *adev) AssignedDevice *dev = adev->assigned_dev; int irq, r = 0; + /* Interrupt PIN 0 means don't use INTx */ + if (pci_read_byte(dev->pdev, PCI_INTERRUPT_PIN) == 0) + return 0; + irq = pci_map_irq(&dev->dev, dev->intpin); irq = piix_get_irq(irq); -- 1.5.4.5