Re: [PATCH 13/16] kvm: enable MSI-X capabilty for assigned device

[Alex Williamson <alex.williamson@hp.com>]

On Tue, 2009-03-17 at 11:50 +0800, Sheng Yang wrote:
> +    if (*ctrl_word & PCI_MSIX_ENABLE) {
> +        if (assigned_dev_update_msix_mmio(pci_dev) < 0) {
> +            perror("assigned_dev_update_msix_mmio");
> +            return;
> +        }
> +        if (kvm_assign_irq(kvm_context, &assigned_irq_data) < 0) {
> +            perror("assigned_dev_enable_msix: assign irq");
> +            return;
> +        }
> +        assigned_dev->irq_requested_type = assigned_irq_data.flags;
> +    }
> +}

Do we need some disable logic here?  If I toggle a bnx2 NIC in a guest,
I get the following when it attempts to come back up:

MSI-X entry number is zero!
assigned_dev_update_msix_mmio: No such device or address

Thanks,

Alex