From: Sheng Yang <sheng@linux.intel.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, Alex Williamson <alex.williamson@hp.com>,
Sheng Yang <sheng@linux.intel.com>
Subject: [PATCH] kvm: Fix wrong counting of MSI-X table size
Date: Wed, 8 Apr 2009 10:30:56 +0800 [thread overview]
Message-ID: <1239157856-15295-1-git-send-email-sheng@linux.intel.com> (raw)
The PCI spec said...
System software reads this field to determine the MSI-X Table Size *N*,
which is encoded as *N-1*. For example, a returned value of “00000000011”
indicates a table size of 4.
Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
qemu/hw/device-assignment.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
index 09e54ae..f33ce3c 100644
--- a/qemu/hw/device-assignment.c
+++ b/qemu/hw/device-assignment.c
@@ -818,6 +818,7 @@ static int assigned_dev_update_msix_mmio(PCIDevice *pci_dev)
entries_max_nr = pci_dev->config[pos + 2];
entries_max_nr &= PCI_MSIX_TABSIZE;
+ entries_max_nr += 1;
/* Get the usable entry number for allocating */
for (i = 0; i < entries_max_nr; i++) {
--
1.5.4.5
next reply other threads:[~2009-04-08 2:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 2:30 Sheng Yang [this message]
2009-04-09 15:35 ` [PATCH] kvm: Fix wrong counting of MSI-X table size Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239157856-15295-1-git-send-email-sheng@linux.intel.com \
--to=sheng@linux.intel.com \
--cc=alex.williamson@hp.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox