From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark McLoughlin Subject: Re: [PATCH] kvm: qemu: net: unbreak tap networking Date: Tue, 28 Apr 2009 11:10:22 +0100 Message-ID: <1240913422.1368.22.camel@blaa> References: <1240908500-25598-1-git-send-email-markmc@redhat.com> <49F6C54A.1060005@redhat.com> Reply-To: Mark McLoughlin Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:60331 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757225AbZD1KKZ (ORCPT ); Tue, 28 Apr 2009 06:10:25 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3SAAPtB007313 for ; Tue, 28 Apr 2009 06:10:25 -0400 In-Reply-To: <49F6C54A.1060005@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 2009-04-28 at 11:58 +0300, Avi Kivity wrote: > Mark McLoughlin wrote: > > A recent merge broke tap networking because qemu_send_packet() > > now always returns -EAGAIN causing tap to try and resend the > > same packet forever. > > > > Fix by having qemu_send_packet() return the status from the > > qemu_deliver_packet() of the packet in question, rather than > > any packets which happened to have been queued up during the > > delivery of the original packet. > > > > Applied, thanks. > > What's the outlook on converging with upstream here? Otherwise I'll > keep breaking net on every merge. Yeah, I was getting close to something sane and then got distracted by other things. Soon, hopefully. Cheers, Mark.