From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark McLoughlin Subject: Re: virtio-net not working with the latest qemu-kvm git Date: Tue, 05 May 2009 09:56:47 +0100 Message-ID: <1241513807.5433.20.camel@blaa> References: <1241455836.16915.20.camel@w-sridhar.beaverton.ibm.com> <1241459088.26045.1.camel@lappy> Reply-To: Mark McLoughlin Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Sridhar Samudrala , kvm@vger.kernel.org To: Alex Williamson Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44206 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139AbZEEI4x (ORCPT ); Tue, 5 May 2009 04:56:53 -0400 In-Reply-To: <1241459088.26045.1.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2009-05-04 at 11:44 -0600, Alex Williamson wrote: > On Mon, 2009-05-04 at 09:50 -0700, Sridhar Samudrala wrote: > > When i moved to the latest qemu-kvm git tree from kvm-85, i noticed that > > networking stopped working between the host and the guest. > > It started working when i put the device in promiscuos mode by running > > tcpdump in background on the guest. > > > > After browsing through the recent patches, i found that the following commit > > is causing the regression. > > > > Remove stray GSO code from virtio_net (Mark McLoughlin) > > http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=commitdiff;h=559a8f45f34cc50d1a60b4f67a06614d506b2e01 > > > > The comment doesn't seem to match with the code that is removed with this patch. > > Yep, I agree, the removed code is not bogus. We have to skip the vnet > header to to get to the ethernet header, which we do the filtering on. The code was removed in upstream qemu.git, but we need it re-instated in qemu-kvm.git. Just sent a patch to do that. Thanks, Mark.