From: Weidong Han <weidong.han@intel.com>
To: dwmw2@infradead.org, suresh.b.siddha@intel.com, mingo@elte.hu
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
kvm@vger.kernel.org, Weidong Han <weidong.han@intel.com>
Subject: [PATCH 1/2] Intel-IOMMU, intr-remap: set the whole 128bits of irte when modify/free it
Date: Thu, 7 May 2009 14:16:35 +0800 [thread overview]
Message-ID: <1241676996-27406-1-git-send-email-weidong.han@intel.com> (raw)
Interrupt remapping table entry is 128bits. Currently, it only sets low
64bits of irte in modify_irte and free_irte. This ignores high 64bits
setting of irte, that means source-id setting will be ignored. This patch
sets the whole 128bits of irte when modify/free it. Following source-id
checking patch depends on this.
Signed-off-by: Weidong Han <weidong.han@intel.com>
---
drivers/pci/intr_remapping.c | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/intr_remapping.c b/drivers/pci/intr_remapping.c
index f5e0ea7..946e170 100644
--- a/drivers/pci/intr_remapping.c
+++ b/drivers/pci/intr_remapping.c
@@ -309,7 +309,8 @@ int modify_irte(int irq, struct irte *irte_modified)
index = irq_iommu->irte_index + irq_iommu->sub_handle;
irte = &iommu->ir_table->base[index];
- set_64bit((unsigned long *)irte, irte_modified->low);
+ set_64bit((unsigned long *)&irte->low, irte_modified->low);
+ set_64bit((unsigned long *)&irte->high, irte_modified->high);
__iommu_flush_cache(iommu, irte, sizeof(*irte));
rc = qi_flush_iec(iommu, index, 0);
@@ -386,8 +387,11 @@ int free_irte(int irq)
irte = &iommu->ir_table->base[index];
if (!irq_iommu->sub_handle) {
- for (i = 0; i < (1 << irq_iommu->irte_mask); i++)
- set_64bit((unsigned long *)(irte + i), 0);
+ for (i = 0; i < (1 << irq_iommu->irte_mask); i++) {
+ set_64bit((unsigned long *)&irte->low, 0);
+ set_64bit((unsigned long *)&irte->high, 0);
+ irte++;
+ }
rc = qi_flush_iec(iommu, index, irq_iommu->irte_mask);
}
--
1.6.0.4
next reply other threads:[~2009-05-07 6:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 6:16 Weidong Han [this message]
2009-05-07 6:16 ` [PATCH 2/2] Intel-IOMMU, intr-remap: source-id checking Weidong Han
2009-05-07 18:19 ` Suresh Siddha
2009-05-11 6:22 ` Han, Weidong
2009-05-11 13:20 ` Ingo Molnar
2009-05-18 9:46 ` Han, Weidong
2009-05-19 9:32 ` Ingo Molnar
2009-05-19 10:34 ` Han, Weidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241676996-27406-1-git-send-email-weidong.han@intel.com \
--to=weidong.han@intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox