* [PATCH] KVM: fix cpuid E2BIG handling for extended request types
@ 2009-05-12 11:36 Mark McLoughlin
2009-05-17 22:41 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Mark McLoughlin @ 2009-05-12 11:36 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm, Mark McLoughlin
If we run out of cpuid entries for extended request types
we should return -E2BIG, just like we do for the standard
request types.
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
---
arch/x86/kvm/x86.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index fd0a571..451e5eb 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1394,6 +1394,10 @@ static int kvm_dev_ioctl_get_supported_cpuid(struct kvm_cpuid2 *cpuid,
for (func = 0x80000001; func <= limit && nent < cpuid->nent; ++func)
do_cpuid_ent(&cpuid_entries[nent], func, 0,
&nent, cpuid->nent);
+ r = -E2BIG;
+ if (nent >= cpuid->nent)
+ goto out_free;
+
r = -EFAULT;
if (copy_to_user(entries, cpuid_entries,
nent * sizeof(struct kvm_cpuid_entry2)))
--
1.6.0.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: fix cpuid E2BIG handling for extended request types
2009-05-12 11:36 [PATCH] KVM: fix cpuid E2BIG handling for extended request types Mark McLoughlin
@ 2009-05-17 22:41 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2009-05-17 22:41 UTC (permalink / raw)
To: Mark McLoughlin; +Cc: kvm
Mark McLoughlin wrote:
> If we run out of cpuid entries for extended request types
> we should return -E2BIG, just like we do for the standard
> request types.
>
Applied, thanks.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-17 22:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-12 11:36 [PATCH] KVM: fix cpuid E2BIG handling for extended request types Mark McLoughlin
2009-05-17 22:41 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox