Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR)

Arnd Bergmann
2009-05-14T15:50:13Z

On Thursday 14 May 2009, Avi Kivity wrote:
>
> There aren't the real kernel headers, just cheap copies carried in
> qemu-kvm.git which have been appropriately postprocessed.  We do this
> since the kvm external module can run on a much older kernel, so there
> is no natural place to find it headers.
>

Sorry for the confusion on my part. I was aware of the sanitized
kernel headers, but was mislead by the line

kerneldir=/lib/modules/$(uname -r)/build

in kvm/user/configure. What I didn't realize is that this
always gets overridden by kvm/configure.
Maybe we can change the default in kvm/user/configure to
something more sensible:
---
[PATCH] kvm: user: fix default kerneldir

calling ./configure in kvm/user sets the kerneldir to the
currently running kernel, which is incorrect for user code.
This changes the default to the sanitized header files from
the kvm/kernel directory.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/kvm/user/configure b/kvm/user/configure
index efb8705..858a519 100755
--- a/kvm/user/configure
+++ b/kvm/user/configure
@@ -1,7 +1,7 @@
#!/bin/bash

prefix=/usr/local
-kerneldir=/lib/modules/$(uname -r)/build
+kerneldir="$(dirname $0)/../kernel"
cc=gcc
ld=ld
objcopy=objcopy