From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH v3] kvm: Use a bitmap for tracking used GSIs Date: Wed, 13 May 2009 06:19:35 -0600 Message-ID: <1242217175.4786.50.camel@2710p.home> References: <20090508222925.5119.94814.stgit@dl380g6-3.ned.telco.ned.telco> <20090512220142.5663.72948.stgit@dl380g6-3.ned.telco.ned.telco> <20090513070451.GB31139@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, sheng.yang@intel.com To: "Michael S. Tsirkin" Return-path: Received: from g5t0006.atlanta.hp.com ([15.192.0.43]:18061 "EHLO g5t0006.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751202AbZEMMTj (ORCPT ); Wed, 13 May 2009 08:19:39 -0400 In-Reply-To: <20090513070451.GB31139@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2009-05-13 at 10:04 +0300, Michael S. Tsirkin wrote: > On Tue, May 12, 2009 at 04:07:15PM -0600, Alex Williamson wrote: > > @@ -286,6 +289,9 @@ kvm_context_t kvm_init(struct kvm_callbacks *callbacks, > > int fd; > > kvm_context_t kvm; > > int r; > > +#ifdef KVM_CAP_IRQ_ROUTING > > Let's kill all these ifdefs. Or at least, let's not add them. AFAICT, they're still used both for builds against older kernels and architectures that don't support it. Hollis just added the one around kvm_get_irq_route_gsi() 10 days ago to fix ppc build. Has it since been deprecated? Thanks, Alex