[KVM-AUTOTEST PATCH] Instead of trying to remove kvm modules with rmmod, use modprobe -r, as it handles module dependencies better

public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed

From: Lucas Meneghel Rodrigues <mrodrigu@redhat.com>
To: kvm@vger.kernel.org
Subject: [KVM-AUTOTEST PATCH] Instead of trying to remove kvm modules with rmmod, use modprobe -r, as it handles module dependencies better
Date: Thu, 14 May 2009 18:53:46 -0300	[thread overview]
Message-ID: <1242338026.2554.44.camel@localhost.localdomain> (raw)

In certain situations, trying to do a rmmod on the kvm modules might
generate errors, as there is a chain of dependencies involved. Instead,
let's use modprobe -r, as it handles dependencies.

Signed-off-by: Lucas Meneghel Rodrigues <mrodrigu@redhat.com>

diff --git a/client/tests/kvm_runtest_2/kvm_install.py b/client/tests/kvm_runtes
index dbf8401..c27c6c7 100755
--- a/client/tests/kvm_runtest_2/kvm_install.py
+++ b/client/tests/kvm_runtest_2/kvm_install.py
@@ -192,9 +192,9 @@ def __load_kvm_modules():
     #utils.system("pkill qemu 1>/dev/null 2>&1", ignore_status=True)
     utils.system("pkill qemu", ignore_status=True)
     #if utils.system("grep kvm_%s /proc/modules 1>/dev/null" % vendor, ignore_s
-    utils.system("/sbin/rmmod kvm_%s" % vendor, ignore_status=True)
+    utils.system("/sbin/modprobe -r kvm_%s" % vendor, ignore_status=True)
     #if utils.system("grep kvm /proc/modules 1>/dev/null", ignore_status=True) 
-    utils.system("/sbin/rmmod kvm", ignore_status=True)
+    utils.system("/sbin/modprobe -r kvm", ignore_status=True)
 
     if utils.system("grep kvm /proc/modules 1>/dev/null", ignore_status=True) =
         message = "Failed to remove old KVM modules"

-- 
Lucas Meneghel Rodrigues
Software Engineer (QE)
Red Hat - Emerging Technologies

next             reply	other threads:[~2009-05-14 22:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-14 21:53 Lucas Meneghel Rodrigues [this message]
2009-05-19 17:26 ` [KVM-AUTOTEST PATCH] Instead of trying to remove kvm modules with rmmod, use modprobe -r, as it handles module dependencies better Mike Burns
2009-05-24 14:54   ` Avi Kivity

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:dbf8401 dfblob:c27c6c7 )
 OR (
bs:"[KVM-AUTOTEST PATCH] Instead of trying to remove kvm modules with rmmod, use modprobe -r, as it handles module dependencies better" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242338026.2554.44.camel@localhost.localdomain \
    --to=mrodrigu@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox