public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: kvm@vger.kernel.org
Cc: joerg.roedel@amd.com
Subject: [PATCH 3/6] Emulator: Inject #PF when page was not found
Date: Fri, 15 May 2009 10:22:17 +0200	[thread overview]
Message-ID: <1242375740-31222-4-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1242375740-31222-3-git-send-email-agraf@suse.de>

If we couldn't find a page on read_emulated, it might be a good
idea to tell the guest about that and inject a #PF.

We do the same already for write faults. I don't know why it was
not implemented for reads.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 arch/x86/kvm/x86.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 5fcde2c..5aa1219 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -2131,10 +2131,13 @@ static int emulator_read_emulated(unsigned long addr,
 		goto mmio;
 
 	if (kvm_read_guest_virt(addr, val, bytes, vcpu)
-				== X86EMUL_CONTINUE)
+				== X86EMUL_CONTINUE) {
 		return X86EMUL_CONTINUE;
-	if (gpa == UNMAPPED_GVA)
+	}
+	if (gpa == UNMAPPED_GVA) {
+		kvm_inject_page_fault(vcpu, addr, 0);
 		return X86EMUL_PROPAGATE_FAULT;
+	}
 
 mmio:
 	/*
-- 
1.6.0.2


  reply	other threads:[~2009-05-15  8:22 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-15  8:22 [PATCH 0/6] Add rudimentary Hyper-V guest support Alexander Graf
2009-05-15  8:22 ` [PATCH 1/6] Add definition for IGNNE MSR Alexander Graf
2009-05-15  8:22   ` [PATCH 2/6] MMU: don't bail on PAT bits in PTE Alexander Graf
2009-05-15  8:22     ` Alexander Graf [this message]
2009-05-15  8:22       ` [PATCH 4/6] Implement Hyper-V MSRs Alexander Graf
2009-05-15  8:22         ` [PATCH 5/6] Nested SVM: Implement INVLPGA Alexander Graf
2009-05-15  8:22           ` [PATCH 6/6] Nested SVM: Improve interrupt injection Alexander Graf
2009-05-17  6:48             ` Gleb Natapov
2009-05-17  8:10               ` Alexander Graf
2009-05-18 11:47               ` Alexander Graf
2009-05-15 13:43           ` [PATCH 5/6] Nested SVM: Implement INVLPGA Joerg Roedel
2009-05-17 20:02             ` Avi Kivity
2009-05-17 20:03               ` Avi Kivity
2009-05-18 18:46                 ` Marcelo Tosatti
2009-05-18 13:00             ` Alexander Graf
2009-05-17  9:54         ` [PATCH 4/6] Implement Hyper-V MSRs Avi Kivity
2009-05-17 19:57           ` Alexander Graf
2009-05-17 20:00             ` Avi Kivity
2009-05-17 20:27               ` Alexander Graf
2009-05-17 20:37               ` Alexander Graf
2009-05-15 13:40       ` [PATCH 3/6] Emulator: Inject #PF when page was not found Joerg Roedel
2009-05-17 19:59       ` Avi Kivity
2009-05-17 20:25         ` Alexander Graf
2009-05-17 20:58           ` Avi Kivity
2009-05-18 12:55             ` Alexander Graf
2009-05-15 10:25     ` [PATCH 2/6] MMU: don't bail on PAT bits in PTE Michael S. Tsirkin
2009-05-15 10:53       ` Alexander Graf
2009-05-15 13:19         ` Joerg Roedel
2009-05-17  9:51           ` Avi Kivity
2009-05-15 10:47 ` [PATCH 0/6] Add rudimentary Hyper-V guest support Alexander Graf
2009-05-17 21:08   ` Avi Kivity
2009-05-18 12:45     ` Alexander Graf
2009-05-18 13:29       ` Avi Kivity
2009-05-18 13:35         ` Alexander Graf
2009-05-18 13:44           ` Avi Kivity
2009-05-18 15:15         ` Alexander Graf
2009-05-18 15:20           ` Avi Kivity
2009-05-18 15:24             ` Alexander Graf
2009-05-18 15:28               ` Avi Kivity
2009-05-18 15:32                 ` Alexander Graf
2009-05-18 15:35                   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242375740-31222-4-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=joerg.roedel@amd.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox