Re: [PATCH -v3] KVM: MCE: Add MCE support to KVM

Avi Kivity
2009-05-25T18:09:35Z

Jan Kiszka wrote:
> Avi Kivity wrote:
>
>> Huang Ying wrote:
>>
>>> The related MSRs are emulated. MCE capability is exported via
>>> extension KVM_CAP_MCE and ioctl KVM_X86_GET_MCE_CAP_SUPPORTED. A new
>>> vcpu ioctl command KVM_X86_SETUP_MCE is used to setup MCE emulation
>>> such as the mcg_cap. MCE is injected via vcpu ioctl command
>>> KVM_X86_SET_MCE. Extended machine-check state (MCG_EXT_P) and CMCI are
>>> not implemented.
>>>
>>>
>>>
>> Applied, thanks.
>>
>>
>
> This patch breaks kvm build for 32-bit hosts.
>

Strange, I build-test on i386. What's your failure?

> Is the KVM MCE interface completely or only partially limited to x86-64,
> ie. can I completely #ifdef it away on 32-bit hosts (including
> KVM_CAP_MCE) or is this more complicated?
>

I don't see any reason to limit it to x86_64?

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.