From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark McLoughlin <markmc@redhat.com>
Subject: Re: [PATCH 11/17] net: drop packet from tap device if all NICs are
 down
Date: Tue, 19 May 2009 18:52:37 +0100
Message-ID: <1242755557.9151.11.camel@blaa>
References: <1242574999-20887-1-git-send-email-aliguori@us.ibm.com>
	 <1242574999-20887-12-git-send-email-aliguori@us.ibm.com>
Reply-To: Mark McLoughlin <markmc@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Glauber Costa <glommer@gmail.com>,
	Avi Kivity <avi@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:38860 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753935AbZESRwk (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 19 May 2009 13:52:40 -0400
In-Reply-To: <1242574999-20887-12-git-send-email-aliguori@us.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, 2009-05-17 at 10:43 -0500, Anthony Liguori wrote:
> From: Mark McLoughlin <markmc@redhat.com>
> 
> If you do e.g. "set_link virtio.0 down" and there are packets
> pending on the tap interface, we currently buffer a packet
> and constantly try and send it until the link is up again.
> 
> We actually just want to drop the packet if the NIC is down.
> Upstream qemu already does this, we just differ because we
> buffer packets from the tap interface.
> 
> [aliguori: rebased this patch on stable.  Mark, please review and Ack]
> 
> Reported-by: Yan Vugenfirer <yvugenfi@redhat.com>
> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
> Signed-off-by: Avi Kivity <avi@redhat.com>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Looks good to me.

Cheers,
Mark.