From: Peter Zijlstra <peterz@infradead.org>
To: Avi Kivity <avi@redhat.com>
Cc: Mark Langsdorf <mark.langsdorf@amd.com>,
Joerg Roedel <joerg.roedel@amd.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][retry 3] Add support for Pause Filtering to AMD SVM
Date: Wed, 20 May 2009 11:10:16 +0200 [thread overview]
Message-ID: <1242810616.26820.562.camel@twins> (raw)
In-Reply-To: <4A13C7B0.10507@redhat.com>
On Wed, 2009-05-20 at 12:04 +0300, Avi Kivity wrote:
> Peter Zijlstra wrote:
> >> It's a fully virtualized guest. There's no way to get this without
> >> patching the guest kernel.
> >>
> >
> > Yes there is.. virtualized monitor-wait stuff coupled with a
> > monitor-wait based spinlock implementation.
> >
>
> That only works if the guest uses monitor/mwait. Not all of the guests
> are under our control. I don't know whether Windows uses
> monitor/mwait. Further, we don't have timed exits on mwait like we do
> with pause.
Ugh, you really care about crap like windows?
> I've also heard that monitor/mwait are very slow and only usable on idle
> loop stuff.
Yeah, current implementations suck, doesn't mean it has to stay that
way.
> > Once we go change silicon, you might as well do it right.
> >
>
> None of the major x86 vendors are under my control.
I thought this patch came from AMD, who changed their silicon so 'solve'
one of these virt problems.
/me goes hide again, and pretend all of virt doesn't exist :-) Think
happy thoughts.
next prev parent reply other threads:[~2009-05-20 9:10 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200905050909.58583.mark.langsdorf@amd.com>
[not found] ` <20090507135522.GJ4059@amd.com>
2009-05-07 15:00 ` [PATCH][retry 1] Add support for Pause Filtering to AMD SVM Mark Langsdorf
2009-05-07 15:31 ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 14:15 ` [PATCH][retry " Ingo Molnar
2009-05-11 14:24 ` Avi Kivity
2009-05-11 14:33 ` Ingo Molnar
2009-05-11 14:51 ` Avi Kivity
2009-05-11 14:59 ` Ingo Molnar
2009-05-11 15:12 ` Avi Kivity
2009-05-11 15:18 ` Ingo Molnar
2009-05-11 15:28 ` Avi Kivity
2009-05-11 15:36 ` Langsdorf, Mark
2009-05-11 15:40 ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 15:58 ` [PATCH][retry 1] Add support for Pause Filtering to AMDSVM Langsdorf, Mark
2009-05-11 15:01 ` [PATCH][retry 1] Add support for Pause Filtering to AMD SVM Peter Zijlstra
2009-05-11 15:06 ` Avi Kivity
2009-05-11 14:42 ` [PATCH][KVM][retry " Peter Zijlstra
2009-05-11 15:05 ` [PATCH][retry " Avi Kivity
2009-05-08 17:03 ` [PATCH][retry 2] " Mark Langsdorf
2009-05-08 18:44 ` Avi Kivity
2009-05-08 18:47 ` Langsdorf, Mark
2009-05-19 18:56 ` [PATCH][retry 3] " Mark Langsdorf
2009-05-20 7:40 ` [PATCH][KVM][retry " Ingo Molnar
2009-05-20 7:59 ` [PATCH][retry " Peter Zijlstra
2009-05-20 8:38 ` Avi Kivity
2009-05-20 8:42 ` Peter Zijlstra
2009-05-20 8:49 ` Avi Kivity
2009-05-20 8:54 ` Peter Zijlstra
2009-05-20 9:04 ` Avi Kivity
2009-05-20 9:10 ` Peter Zijlstra [this message]
2009-05-20 9:17 ` Avi Kivity
2009-05-20 13:52 ` Langsdorf, Mark
2009-05-20 12:00 ` Avi Kivity
2009-05-20 22:25 ` [PATCH][retry 4] " Mark Langsdorf
2009-05-21 8:47 ` Avi Kivity
2009-07-08 5:19 ` Sheng Yang
2009-07-08 14:59 ` Langsdorf, Mark
2009-07-09 1:50 ` Sheng Yang
2009-07-22 22:40 ` Langsdorf, Mark
2009-08-05 9:08 ` Zhai, Edwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242810616.26820.562.camel@twins \
--to=peterz@infradead.org \
--cc=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox